Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: postgres-adoption.md add metadata title, description, and better first-readable-title #2346

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

Ivansete-status
Copy link
Collaborator

Description

Simple PR that adds metadata information (title and description), needed to make the Docusaurus platform to properly parse it.

@Ivansete-status Ivansete-status marked this pull request as ready for review January 10, 2024 15:34
@Ivansete-status Ivansete-status self-assigned this Jan 10, 2024
@Ivansete-status
Copy link
Collaborator Author

The commit d6b5364 is motivated by @fryorcraken comments on Discord:
image

Copy link
Contributor

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never used Docusaurus before not sure my review would be of any value.

@Ivansete-status
Copy link
Collaborator Author

I never used Docusaurus before not sure my review would be of any value.

Thanks for the approval! Me neither, I just applied the @fryorcraken 's recommendation:
image

@Ivansete-status Ivansete-status merged commit 2f8e8bc into master Jan 12, 2024
8 checks passed
@Ivansete-status Ivansete-status deleted the add-title-desc-to-postgres-docs branch January 12, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants