Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prioritise yamux above mplex #2417

Merged
merged 4 commits into from
Feb 17, 2024
Merged

feat: prioritise yamux above mplex #2417

merged 4 commits into from
Feb 17, 2024

Conversation

jm-clius
Copy link
Contributor

@jm-clius jm-clius commented Feb 9, 2024

  • build switch with yamux the preferred multiplexing protocol above mplex
  • update underlying nim-libp2p

Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link

github-actions bot commented Feb 9, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2417

Built from 5a91a2e

@jm-clius
Copy link
Contributor Author

Since this is a behavioural change, we should merge this only after cutting the release. cc @NagyZoltanPeter @gabrielmer

@NagyZoltanPeter
Copy link
Contributor

It doesn't bother the release. You can merge it to master anytime.

@jm-clius jm-clius merged commit ce151ef into master Feb 17, 2024
10 checks passed
@jm-clius jm-clius deleted the feat/enable-yamux branch February 17, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants