fix: check max message size in validator according to configured value #2424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from 7692bdc |
alrevuelta
reviewed
Feb 13, 2024
Ivansete-status
approved these changes
Feb 14, 2024
gabrielmer
deleted the
max-message-size-configurable-for-clusterId-not-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Maximum message size is a configurable parameter. Therefore, we're updating the validator that we run in our REST handlers to check against the configured value.
Notice that for clusterId=1, the configuration is overriden to the Waku Network's max message size during app startup.
nwaku/apps/wakunode2/wakunode2.nim
Line 78 in 50308ed
Changes
Issue
closes #2406