Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add 150 kB to msg size histogram metric #2430

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

vpavlin
Copy link
Member

@vpavlin vpavlin commented Feb 14, 2024

Description

With the change of default message max size to 140 kB, we are missing some details in the message size histogram

image

Changes

This PR adds 150 kB bucket, so that we can see number of messages between 100 - 150 kB. I left the rest in there for the case of non-TWN networks

  • add 150 bucket to msg size metrics
  • ...

Copy link

github-actions bot commented Feb 14, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2430-rln-v2-false

Built from 2c98dd4

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!
As a suggestion, we could also add a couple of buckets:
75 and 125

@jm-clius
Copy link
Contributor

@vpavlin anything needed to merge this? Follow-up suggestions can be introduced in a subsequent PR, if necessary.

@vpavlin vpavlin force-pushed the feat/add-150-msg-size-histo branch from 749efff to 1fbccdb Compare March 14, 2024 10:03
@vpavlin vpavlin force-pushed the feat/add-150-msg-size-histo branch from e40519b to 987a5c3 Compare March 14, 2024 10:04
@vpavlin vpavlin merged commit 2c1391d into master Mar 14, 2024
14 of 15 checks passed
@vpavlin vpavlin deleted the feat/add-150-msg-size-histo branch March 14, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants