fix(rln-relay): handle empty metadata returned by getMetadata proc #2516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
added
the
E:RLN on mainnet
rymnc
commented
Mar 6, 2024
Comment on lines
672
to
673
| elif metadataGetRes.get().isSome(): | ||
| let metadata = metadataGetRes.get().get() |
There was a problem hiding this comment.
not the cleanest, but oh well
rymnc
changed the title
|
You can find the image built from this PR at Built from 28977e5 |
gabrielmer
approved these changes
Mar 7, 2024
Ivansete-status
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR silences the execution error that is received when trying to fetch the rln metadata from the db.
Zerokit's PR: vacp2p/zerokit#231
If it returns a buf of len 0, then we assume the metadata is not found, and proceed execution as usual.
Changes
How to test
make -j16 testIssue
closes #2471