fix(rest): filter/v2/subscriptions response #2529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-ramos
requested review from
gabrielmer,
NagyZoltanPeter and
Ivansete-status
|
You can find the image built from this PR at Built from c680208 |
richard-ramos
force-pushed
the
fix/filter-response
branch
from
6e4a698
to
7f6d4ff
Compare
NagyZoltanPeter
approved these changes
Mar 13, 2024
Ivansete-status
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
LGTM! Thanks! 💯
I wonder if we should adapt the openapi definitions in https://github.com/waku-org/waku-rest-api
richard-ramos
force-pushed
the
fix/filter-response
branch
from
7f6d4ff
to
5921d91
Compare
richard-ramos
force-pushed
the
fix/filter-response
branch
from
5921d91
to
8709850
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Returns a "OK" for the response when subscription is succesful, and also removes the status code from the response as it is not part of the API. Ping responses also return "OK" when succesful.
Issue
closes #2286