chore: Better postgres duplicate insert #2535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR may contain changes to database schema of one of the drivers. If you are introducing any changes to the schema, make sure the upgrade from the latest release to this change passes without any errors/issues. Please make sure the label |
|
You can find the image built from this PR at Built from 54a6012 |
The insert does not fail when duplicate, it returns a positive response when doing 'put' of a duplicated row. The test is adapted so that we just check that the number of messages doesn't grow after trying to add a duplicated row.
Ivansete-status
force-pushed
the
better-postgres-duplicate-insert
branch
from
e07e955
to
1ff0085
Compare
Ivansete-status
requested review from
SionoiS,
jm-clius,
NagyZoltanPeter and
jakubgs
NagyZoltanPeter
approved these changes
Mar 18, 2024
jakubgs
approved these changes
Mar 18, 2024
Correct |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a suggestion
After comparing insertion times with ~30.000 samples, within the
archivemodule, these are the avg insert times:Then, this solution makes it even smoother the insertion. Thanks for such a suggestion @jakubgs !
Changes
ON CONFLICT DO NOTHING;in the insert statementHow to test
source env.shnim c -r -d:chronicles_log_level=DEBUG -d:release -d:postgres -d:rln --passL:librln_v0.3.4.a --passL:-lm -d:nimDebugDlOpen ./tests/waku_archive/test_driver_postgres.nimIssue
closes #2526
closes status-im/infra-status#26