Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): unique comment_tag to reference rln version #2613

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Apr 22, 2024

Description

There is a race condition for the container-image.yml job that replaces comments with rln-v2 true and rln-v2 false images.
There should be separate comments for both versions.

Changes

  • Alter comment_tag in the container-image.yml job

Copy link

github-actions bot commented Apr 22, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2613-rln-v2-false

Built from 7145f4a

@rymnc rymnc marked this pull request as ready for review April 22, 2024 14:34
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@rymnc rymnc merged commit 2c01fa0 into master Apr 22, 2024
14 of 16 checks passed
@rymnc rymnc deleted the fix-container-image-comment-race branch April 22, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants