refactor: simplify app.nim and move discovery items to appropriate modules #2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from efe6753 |
|
You can find the image built from this PR at Built from efe6753 |
Ivansete-status
requested review from
gabrielmer,
SionoiS,
NagyZoltanPeter and
chaitanyaprem
gabrielmer
approved these changes
May 1, 2024
SionoiS
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplify code to make it easier to start a node from both
wakunode2andlibwaku.Issue
migrate DiscV5 and DNS Discovery from app.nim to waku_node.nim- #2452