chore: move code from wakunode2 to a more generic place, waku #2670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivansete-status
changed the title
|
You can find the image built from this PR at Built from 0ca1f4f |
|
You can find the image built from this PR at Built from 0ca1f4f |
Ivansete-status
force-pushed
the
refactor-init
branch
from
aa56fc3
to
eca19d6
Compare
Ivansete-status
added a commit
that referenced
this pull request
May 14, 2024
* testlib/wakunode.nim: not use cluster-id == 1 to avoid test rln by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves some initialization logic from
apps/wakunode2/wakunode2.nimtowaku/factory/waku.nim, aiming to achieve same behaviour betweenwakunode2andlibwaku.