feat: store v3 return pubsub topics #2676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jm-clius
approved these changes
May 7, 2024
| @@ -56,6 +56,7 @@ type | |||
| ArchiveResponse* = object | |||
| hashes*: seq[WakuMessageHash] | |||
| messages*: seq[WakuMessage] | |||
| topics*: seq[PubsubTopic] | |||
There was a problem hiding this comment.
Mmm. Wouldn't it be better to return seq[(message, topic)] to keep the 1:1 association explicit?
There was a problem hiding this comment.
At the archive driver lvl it's separate then you would use a tuple at the archive lvl then undo the tuple at the Store lvl.
I tried it. I does not make much sense.
|
You can find the image built from this PR at Built from fe7fe3a |
|
You can find the image built from this PR at Built from fe7fe3a |
|
We got a segfault in CI but i can't reproduce locally. :| |
|
Will merge even with CI red as it's unrelated and the issue is being investigated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to unblock Waku Sync work.
Before Store v3 did not return the pubsub topics messages were sent on, now it does.
Follows updated vacp2p/rfc@5d69ab5