chore: Postgres enhance get oldest timestamp #2687
Conversation
|
This PR may contain changes to database schema of one of the drivers. If you are introducing any changes to the schema, make sure the upgrade from the latest release to this change passes without any errors/issues. Please make sure the label |
|
You can find the image built from this PR at Built from 73b4758 |
|
You can find the image built from this PR at Built from 73b4758 |
Ivansete-status
force-pushed
the
postgres-enhance-get-oldest-timestamp
branch
from
ba19625
to
ea24341
Compare
| @@ -701,7 +701,10 @@ proc getInt( | |||
| try: | |||
| retInt = parseInt(str) | |||
| except ValueError: | |||
| return err("exception in getInt, parseInt: " & getCurrentExceptionMsg()) | |||
| return err( | |||
| fmt"exception in getInt, parseInt, str:[{str}] query:[{query}]: " & | |||
There was a problem hiding this comment.
FYI fmt can raise and prevent using raises: [] on procs.
There was a problem hiding this comment.
FYI
fmtcan raise and prevent usingraises: []on procs.
Thanks for the comment! I fixed that even though I cannot link to the actual commit (I had to force-push as I rebased from origin.)
Ivansete-status
force-pushed
the
postgres-enhance-get-oldest-timestamp
branch
from
ea24341
to
784f856
Compare
* postgres: consider also the existing paritions when getting oldest timestamp * test_driver_postgres_query: adapt test to oldest timestamp
Description
This PR enhances the case where, for any reason, there are old empty partitions. In that case of empty partitions, they are not considered when getting the oldest timestamp. Instead, the oldest timestamp was only considered from the oldest row.
Therefore, when "time" retention policy is applied, we should also consider those old-empty partitions so that they can get erased properly.
Issue
closes #2689