fix: add back waku discv5 metrics #2927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from 2b0b7a3 |
gabrielmer
reviewed
Jul 23, 2024
| @@ -211,6 +211,8 @@ proc findRandomPeers*( | |||
| elif wd.predicate.isSome(): | |||
| discoveredRecords = discoveredRecords.filter(wd.predicate.get()) | |||
|
|
|||
| waku_discv5_discovered.inc(discoveredRecords.len) | |||
There was a problem hiding this comment.
The only concern that I have is if we receive the same peer twice, we will update this metric both times.
Another alternative is increasing it in addPeer() if the origin is PeerOrigin.Discv5 after passing the duplicate checks
There was a problem hiding this comment.
🤔 I thought we had another metric for that... I could add both.
This one say number of nodes discovered so maybe we don't filter?
There was a problem hiding this comment.
Sounds good :) Thank you!
gabrielmer
approved these changes
Jul 23, 2024
Ivansete-status
approved these changes
Jul 26, 2024
Co-authored-by: Ivan FB <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that waku discv5 metrics were not used so I added them back.