Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: per limit split of PostgreSQL queries #3008

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

SionoiS
Copy link
Contributor

@SionoiS SionoiS commented Aug 30, 2024

Postgres driver now split queries with more than 100 hashes into multiple ones.

Closes #3006

@SionoiS SionoiS self-assigned this Aug 30, 2024
Copy link

This PR may contain changes to database schema of one of the drivers.

If you are introducing any changes to the schema, make sure the upgrade from the latest release to this change passes without any errors/issues.

Please make sure the label release-notes is added to make sure upgrade instructions properly highlight this change.

Copy link

github-actions bot commented Aug 30, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3008

Built from afd31a7

Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks so much!

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool! Thanks for it 🙌

@SionoiS SionoiS merged commit e1e05af into master Sep 4, 2024
9 of 11 checks passed
@SionoiS SionoiS deleted the chore--update-postgres-hash-limit-handling branch September 4, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: store sync should support syncs of more than 100 msg hashes
3 participants