fix: keys migration (document deserialization error) #624
+54
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeplotean
force-pushed
the
fix/keys-migration
branch
from
8ae003b
to
7df6e30
Compare
mikeplotean
force-pushed
the
fix/keys-migration
branch
from
7df6e30
to
5e50c15
Compare
|
Shouldn't it maybe only be executed on demand? |
it's executed only on data matching the criteria (in this case, jwk keyType having the jwk field as a string). what do you mean by demand? |
mikeplotean
force-pushed
the
fix/keys-migration
branch
2 times, most recently
from
ee19728
to
bdcbb99
Compare
|
|
mikeplotean
force-pushed
the
fix/keys-migration
branch
2 times, most recently
from
04f0a50
to
0b5f6ac
Compare
mikeplotean
force-pushed
the
fix/keys-migration
branch
2 times, most recently
from
d84b1f0
to
7127add
Compare
mikeplotean
force-pushed
the
fix/keys-migration
branch
from
7127add
to
b05fd41
Compare
mikeplotean
force-pushed
the
fix/keys-migration
branch
from
b05fd41
to
207732d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces keys migration to convert jwk keys documents to new format.
Fixes #625
Type of Change
New feature (non-breaking change which adds functionality)Breaking change (fix or feature that would cause existing functionality to not work as expected)This change requires a documentation updateChecklist
If it is a core feature, I have added thorough testsDo we need to implement analytics?Will this be part of a product update? If yes, please write one phrase about this update.I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature works