make check fails

[ulm]

flim-80b8121f05a5a0d7fcfe3e54085467a646dd2028 $ make check
emacs -batch -q -no-site-file -l FLIM-MK -f check-flim NONE NONE \
	NONE package-user-dir

Loading /tmp/portage/app-emacs/flim-1.14.9_p20230809/work/flim-80b8121f05a5a0d7fcfe3e54085467a646dd2028/FLIM-CFG...
Loading /tmp/portage/app-emacs/flim-1.14.9_p20230809/work/flim-80b8121f05a5a0d7fcfe3e54085467a646dd2028/FLIM-ELS...

Loading /tmp/portage/app-emacs/flim-1.14.9_p20230809/work/flim-80b8121f05a5a0d7fcfe3e54085467a646dd2028/tests/test-hmac-md5.el (source)...
Eager macro-expansion failure: (error "Attempt to change byte length of a string")
PACKAGE_LISPDIR=~/.emacs.d/elpa
PREFIX=/usr
LISPDIR=/usr/share/emacs/site-lisp

Error: error ("Eager macro-expansion failure: (error \"Attempt to change byte length of a string\")")
  mapbacktrace(#f(compiled-function (evald func args flags) #<bytecode 0x1229c1aba9ae87ed>))
  debug-early-backtrace()
  debug-early(error (error "Eager macro-expansion failure: (error \"Attempt to change byte length of a string\")"))
  signal(error ("Eager macro-expansion failure: (error \"Attempt to change byte length of a string\")"))
  error("Eager macro-expansion failure: %S" (error "Attempt to change byte length of a string"))
  internal-macroexpand-for-load((let ((func (lambda (case) (lunit-assert (string= (encode-hex-string (hmac-md5 (make-string 50 221) (make-string 16 170))) "56be34521d144c88dbb8c733f0e8b3f6")))) (sym (luna-class-find-or-make-member (luna-find-class 'test-hmac-md5) 'test-hmac-md5-3)) (cache (get 'test-hmac-md5-3 'luna-method-cache))) (and cache (fboundp sym) (mapatoms (lambda (s) (if (memq (symbol-function sym) (symbol-value s)) (unintern s cache))) cache)) (fset sym func) (put sym 'luna-method-qualifier nil)) t)
  eval-buffer(#<buffer  *load*> nil "/tmp/portage/app-emacs/flim-1.14.9_p20230809/work/flim-80b8121f05a5a0d7fcfe3e54085467a646dd2028/tests/test-hmac-md5.el" nil t)
  load-with-code-conversion("/tmp/portage/app-emacs/flim-1.14.9_p20230809/work/flim-80b8121f05a5a0d7fcfe3e54085467a646dd2028/tests/test-hmac-md5.el" "/tmp/portage/app-emacs/flim-1.14.9_p20230809/work/flim-80b8121f05a5a0d7fcfe3e54085467a646dd2028/tests/test-hmac-md5.el" nil nil)
  load("/tmp/portage/app-emacs/flim-1.14.9_p20230809/work/flim-80b8121f05a5a0d7fcfe3e54085467a646dd2028/tests/test-hmac-md5.el" nil nil t)
  load-file("/tmp/portage/app-emacs/flim-1.14.9_p20230809/work/flim-80b8121f05a5a0d7fcfe3e54085467a646dd2028/tests/test-hmac-md5.el")
  (progn (load-file (car files)) (lunit-test-suite-add-test suite (lunit-make-test-suite-from-class (intern (file-name-sans-extension (file-name-nondirectory (car files)))))))
  (if (file-regular-p (car files)) (progn (load-file (car files)) (lunit-test-suite-add-test suite (lunit-make-test-suite-from-class (intern (file-name-sans-extension (file-name-nondirectory (car files))))))))
  (while files (if (file-regular-p (car files)) (progn (load-file (car files)) (lunit-test-suite-add-test suite (lunit-make-test-suite-from-class (intern (file-name-sans-extension (file-name-nondirectory (car files)))))))) (setq files (cdr files)))
  (let ((files (directory-files "tests" t "^test-.*\\.el$")) (suite (lunit-make-test-suite))) (while files (if (file-regular-p (car files)) (progn (load-file (car files)) (lunit-test-suite-add-test suite (lunit-make-test-suite-from-class (intern (file-name-sans-extension (file-name-nondirectory (car files)))))))) (setq files (cdr files))) (lunit suite))
  check-flim()
  command-line-1(("-l" "FLIM-MK" "-f" "check-flim" "NONE" "NONE" "NONE" "package-user-dir"))
  command-line()
  normal-top-level()
make: *** [Makefile:38: check] Error 255

Looks like a problem with unibyte vs multibyte representation. hmac-md5 expects an unibyte string, but (make-string 50 ?\xdd) isn't.

[ikazuhiro]

Should be fixed. Please test on the latest.

[ulm]

This fixes the failure for me. Thank you!

Edit: I see however that the documentation of string-make-unibyte says "This function is obsolete since 26.1". So I wonder if the equivalent of (apply #'unibyte-string (make-list 16 ?\xaa)) couldn't be used everywhere instead?

[ikazuhiro]

Done.