Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASIX: Architecture-Independent StackSnapshot Alignment #3602

Open
theduke opened this issue Feb 22, 2023 · 5 comments
Open

WASIX: Architecture-Independent StackSnapshot Alignment #3602

theduke opened this issue Feb 22, 2023 · 5 comments
Assignees
Labels
🎉 enhancement New feature! lib-wasix Issues related to the WASIX toolchain. priority-low Low priority issue
Milestone

Comments

@theduke
Copy link
Contributor

theduke commented Feb 22, 2023

The StackSnapshot type used by wasix is currently defined as a u128, which creates alignment issues on different CPU architectures, for example because ARM has different alignment requirements.

The type should be replaced to be free of alignment issues, like a multiple u32.

This may also require updates to:

@theduke theduke added 🎉 enhancement New feature! lib-wasix Issues related to the WASIX toolchain. labels Feb 22, 2023
@theduke theduke changed the title WASIX: Solve StackSnapshot Alignment WASIX: Architecture-Independent StackSnapshot Alignment Feb 22, 2023
This was referenced Feb 22, 2023
@ptitSeb ptitSeb added this to the v3.2 milestone Feb 28, 2023
@ptitSeb
Copy link
Contributor

ptitSeb commented Feb 28, 2023

assigned to syrus for later assignment.

@Michael-F-Bryan Michael-F-Bryan added the priority-low Low priority issue label Mar 21, 2023
@ptitSeb ptitSeb modified the milestones: v3.2, v3.3 Apr 13, 2023
@ptitSeb ptitSeb modified the milestones: v3.3, v4.0 Apr 20, 2023
@ptitSeb ptitSeb modified the milestones: v4.0, v4.1 Jun 6, 2023
@ptitSeb
Copy link
Contributor

ptitSeb commented Jun 6, 2023

Main type aligment done. Need some 2nd look on that later.

Copy link

stale bot commented Jun 7, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the 🏚 stale Inactive issues or PR label Jun 7, 2024
@syrusakbary
Copy link
Member

Not stale

Copy link

stale bot commented Jul 7, 2024

Feel free to reopen the issue if it has been closed by mistake.

@stale stale bot closed this as completed Jul 7, 2024
@theduke theduke reopened this Jul 7, 2024
@stale stale bot removed the 🏚 stale Inactive issues or PR label Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 enhancement New feature! lib-wasix Issues related to the WASIX toolchain. priority-low Low priority issue
Projects
None yet
Development

No branches or pull requests

5 participants