Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASIX Snapshot Tests - Replace Raw WASM Files With Source-Level Test Cases #3617

Closed
theduke opened this issue Feb 23, 2023 · 2 comments
Closed
Assignees
Labels
🎉 enhancement New feature! priority-medium Medium priority issue 🏚 stale Inactive issues or PR 🧪 tests I love tests
Milestone

Comments

@theduke
Copy link
Contributor

theduke commented Feb 23, 2023

Currently the WASIX specific functionality (like threading, thread spawning, forking, ...) is only tested with snapshot tests located in tests/integration/cli/tests/snapshot.rs.

Most of these tests were imported as raw WASM files from https://github.com/wasmerio/wasix-libc/tree/main/examples, but also from other repositories by @john-sharratt .

We need to have these tests available as source code and the ability to re-compile when needed.

We should either:

  • move source level tests to this repo and have the ability to build them as part of the build system
  • Move the tests to the wasmerio/wasix repo as a collection of varied test cases , and include that repo as a git submodule
@theduke theduke added 🎉 enhancement New feature! 🧪 tests I love tests labels Feb 23, 2023
@theduke theduke changed the title WASIX Tests WASIX Testsuite Feb 23, 2023
@theduke theduke changed the title WASIX Testsuite WASIX Snapshot Tests - Replace Raw WASM Files With Source-Level Test Cases Feb 23, 2023
@ptitSeb ptitSeb added the priority-medium Medium priority issue label Feb 28, 2023
@ptitSeb ptitSeb added this to the v3.3 milestone Feb 28, 2023
@ptitSeb ptitSeb modified the milestones: v3.3, v4.x Apr 20, 2023
@Michael-F-Bryan Michael-F-Bryan self-assigned this Jun 20, 2023
Copy link

stale bot commented Jun 19, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the 🏚 stale Inactive issues or PR label Jun 19, 2024
Copy link

stale bot commented Jul 20, 2024

Feel free to reopen the issue if it has been closed by mistake.

@stale stale bot closed this as completed Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 enhancement New feature! priority-medium Medium priority issue 🏚 stale Inactive issues or PR 🧪 tests I love tests
Projects
None yet
Development

No branches or pull requests

3 participants