Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the additionalSignupFields feature to getUserFieldsFn #1608

Closed
infomiho opened this issue Dec 21, 2023 · 1 comment
Closed

Change the additionalSignupFields feature to getUserFieldsFn #1608

infomiho opened this issue Dec 21, 2023 · 1 comment
Assignees
Labels

Comments

@infomiho
Copy link
Contributor

infomiho commented Dec 21, 2023

After we introduce the new auth models (#1080) which don't require mixing business logic fields and auth fields on the same User entity, the concept of "additional signup fields" won't make sense anymore. Since, there will be only "business logic user fields" but they are not "additional".

For Google & Github auth methods, we have the getUserFieldsFn which does exactly that - it specifies which User fields to set based on the all available data from e.g. Google like email.

We should convert our additionalSignupFields into getUserFieldsFn but it would receive all the signup form data and then the developer can decide what to put on the User object.

@infomiho infomiho self-assigned this Dec 21, 2023
@infomiho infomiho added the auth label Dec 21, 2023
@sodic sodic added post-0.12.0 enhancement New feature or request labels Mar 5, 2024
@sodic
Copy link
Contributor

sodic commented Mar 6, 2024

Closed by #1583

@sodic sodic closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants