Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodemon crashes when dependencies change #1843

Open
sodic opened this issue Mar 1, 2024 · 0 comments
Open

Nodemon crashes when dependencies change #1843

sodic opened this issue Mar 1, 2024 · 0 comments
Labels
bug Something isn't working post-0.12.0

Comments

@sodic
Copy link
Contributor

sodic commented Mar 1, 2024

Taken from @infomiho's Discord message:

  1. When we enable Google auth for instance, we update the deps and start npm install for the server.
  2. Nodemon crashes since it restarts before we finish the npm install
  3. It stays crashed since it won't restart on changed deps

image

@Martinsos commented:

Aha hm! And it stays crashed, ok that sucks. I guess those deps are maybe too far above, is that the reason? Because they are in the node_modules that is above the server/? Because it seems to me this was not happening before like this, and this would explain it.

Yeah I don't think we have a good way to easily restart nodemon from outside, I remember I was exploring this in the past already and haven't found a simple/nice solution.

I did add a delay for nodemon, after file changes, that was supposed to ensure other smaller chores before it settle down, but yeah that isn't enough for npm install.

I am sure we could do some stuff, but I don't think it is clean/simple.

@sodic sodic added the bug Something isn't working label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working post-0.12.0
Projects
None yet
Development

No branches or pull requests

1 participant