Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs on deploying to Netlify #1999

Closed
infomiho opened this issue Apr 29, 2024 · 2 comments · Fixed by #2041
Closed

Update docs on deploying to Netlify #1999

infomiho opened this issue Apr 29, 2024 · 2 comments · Fixed by #2041
Labels
deployment documentation Improvements or additions to documentation shouldfix We should do/fix this at some point

Comments

@infomiho
Copy link
Contributor

It seems that OAuth redirects don't work properly without using a special _redirect file to set up the redirect on Netlify.

Discord thread: https://ptb.discord.com/channels/686873244791210014/1233257829897605282/1234504751408742460
@infomiho infomiho added the documentation Improvements or additions to documentation label Apr 29, 2024
@sodic
Copy link
Contributor

sodic commented May 2, 2024

Related: #1982

@Martinsos Martinsos added shouldfix We should do/fix this at some point deployment labels May 7, 2024
@infomiho infomiho mentioned this issue May 17, 2024
Merged
@infomiho
Copy link
Contributor Author

After testing it again, it seems that there is no need for a special _redirect file since we already provide a netlify.toml with the needed redirects listed in the config file. This issue will close after we merge #2041

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deployment documentation Improvements or additions to documentation shouldfix We should do/fix this at some point
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes the default netlify.toml in the built web app wasp-lang/wasp
3 participants
@Martinsos @infomiho @sodic