Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Quantile function of Histogram may be giving wrong result #71

Open
keep94 opened this issue Oct 7, 2021 · 0 comments
Open

The Quantile function of Histogram may be giving wrong result #71

keep94 opened this issue Oct 7, 2021 · 0 comments
Labels
histogram

Comments

@keep94
Copy link
Contributor

keep94 commented Oct 7, 2021

On this line,

wavefront-sdk-go/histogram/histogram.go

Line 134 in c06327c

tempTdigest.Add(mean)
, I think we want to call AddWeighted() on the TDigest. Each centroid in the enclosing for loop has a count. By not calling AddWeighted, we are essentially ignoring the count or weight of each centroid when computing the quantile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
histogram
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LukeWinikates @keep94