Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The installation assistant script shoud remove config.yml after deployment #1666

Closed
alberpilot opened this issue Jun 20, 2022 · 4 comments · Fixed by #1679
Closed

The installation assistant script shoud remove config.yml after deployment #1666

alberpilot opened this issue Jun 20, 2022 · 4 comments · Fixed by #1679
Assignees
@miguelfdez99
Labels
installation assistant type/bug Bug issue
Milestone
Release 4.4.0

Comments

@alberpilot
Copy link
Contributor

Currently, the installation assistant leaves a copy of config.yml file out of the .tar assessments file. This file should be contained only in the tar file.

In addition, the file name config.yml should be changed to wazuh-config.yml.
@miguelfdez99 miguelfdez99 self-assigned this Jun 22, 2022
@miguelfdez99 miguelfdez99 mentioned this issue Jun 22, 2022
Merged
@alberpilot
Copy link
Contributor Author

PR to wazuh-documentation needed.

@alberpilot alberpilot linked a pull request Jul 5, 2022 that will close this issue
Remove config.yml after deployment and rename to wazuh-config.yml #1679
Merged
@alberpilot
Copy link
Contributor Author

wazuh/wazuh-documentation#5410 approved.

@alberpilot alberpilot reopened this Jul 18, 2022
@alberpilot
Copy link
Contributor Author

This PR broke the CI and back compatibility of Docker images in 4.3.x.
Due to this, I will revert the changes, and re-do the PR pointing to 4.4.

@miguelfdez99 miguelfdez99 mentioned this issue Jul 18, 2022
Closed
@alberpilot
Copy link
Contributor Author

alberpilot commented Jul 18, 2022 •
edited
Loading

Packages

4.3 only contains the commit about removing the config file after installation. Commit: f1fc7cb
4.3 was merged into 4.4 so the changes are present in the mentioned branch.

Documentation

This PR reverts the change in 4.3: wazuh/wazuh-documentation#5475 and this one wazuh/wazuh-documentation#5477 add it to 4.4, the correct branch.

All changes done for 4.4

@vikman90 vikman90 added this to the Release 4.4.0 milestone Aug 31, 2022
@vikman90 vikman90 added type/bug Bug issue and removed type: bug labels Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miguelfdez99 miguelfdez99

Labels
installation assistant type/bug Bug issue
Projects
No open projects
Release 4.4.0
Status: Done
Milestone
Release 4.4.0
Development

Successfully merging a pull request may close this issue.

Remove config.yml after deployment and rename to wazuh-config.yml wazuh/wazuh-packages
3 participants
@alberpilot @vikman90 @miguelfdez99