Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kibana Plugin is removed and installed in every puppet run #291

Closed
akshatgit opened this issue Aug 28, 2020 · 1 comment · Fixed by #315
Closed

Kibana Plugin is removed and installed in every puppet run #291

akshatgit opened this issue Aug 28, 2020 · 1 comment · Fixed by #315
Assignees

Comments

@akshatgit
Copy link

Since wazuh::kibana is using exec to remove and install the plugin, it is being done in every run. We should restrict its run condition on some changes.

Info: Removing old Wazuh Kibana Plugin...: Scheduling refresh of Service[kibana]
Notice: /Stage[main]/Wazuh::Kibana/Exec[Installing Wazuh App...]/returns: executed successfully
Info: /Stage[main]/Wazuh::Kibana/Exec[Installing Wazuh App...]: Scheduling refresh of Service[kibana]
Notice: /Stage[main]/Wazuh::Kibana/Exec[Removing .wazuh index...]/returns: executed successfully
Info: /Stage[main]/Wazuh::Kibana/Exec[Removing .wazuh index...]: Scheduling refresh of Service[kibana]
Notice: /Stage[main]/Wazuh::Kibana/File[/usr/share/kibana/plugins/wazuh/wazuh.yml]/ensure: defined content as '{md5}b111c5cbe93acf8141bdca29fd7850fa'
Info: /Stage[main]/Wazuh::Kibana/File[/usr/share/kibana/plugins/wazuh/wazuh.yml]: Scheduling refresh of Service[kibana]
Notice: /Stage[main]/Wazuh::Kibana/Exec[Verify Kibana folders owner]/returns: executed successfully
Notice: /Stage[main]/Wazuh::Kibana/Service[kibana]/ensure: ensure changed 'stopped' to 'running'
Info: /Stage[main]/Wazuh::Kibana/Service[kibana]: Unscheduling refresh on Service[kibana]
@Zenidd
Copy link
Contributor

Zenidd commented Aug 28, 2020

Hello again @akshatgit,

In this case, it may be interesting to include a conditional statement checking the current plugin version within the remove/install tasks to ensure idempotence. i.e: check the current plugin version using the onlyif or unless statements.

As soon as our workflow allows us we will address it. Thanks for your contribution !

Greetings,

JP

@akshatgit akshatgit changed the title KIbana Plugin is removed and installed in every puppet run Kibana Plugin is removed and installed in every puppet run Sep 2, 2020
@manuasir manuasir added this to the Sprint - 120 - DevOps milestone Nov 3, 2020
@neonmei neonmei self-assigned this Dec 2, 2020
@neonmei neonmei linked a pull request Dec 2, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants