Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Months displaying improperly. #11

Open
miyagami opened this issue Dec 19, 2018 · 2 comments
Open

Months displaying improperly. #11

miyagami opened this issue Dec 19, 2018 · 2 comments

Comments

@miyagami
Copy link

Two examples.

First, showing overlap of month on announcement:
2018-12-19-013953
My assumption at this time is that the original text was preformatted to place the month title in an exact location, and we broke that by changing the text formatting. I will try to think of another way to present the text to see if it is possible to just fix it through formatting.
Do not let that stop you from trying other routes.

Second, verification of three character month name breaking two character month origin:
2018-12-19-014024
Compare to picture I took earlier, while in Telegram Chat with Mithaldu of it working for month of Jun.
2018-12-19_101558

This implies, not verifies, that in save files, all months except June and October are broken in save file display. June and October are three Kanji origin text, while the rest are two Kanji origin text.

@wchristian
Copy link
Owner

wchristian commented Dec 19, 2018

The first screenshots is rendered by these two:

"新しい月、    となりました!" => { tr =>
"A new month,    , is here!", ok => 'a-csharp 4572711',
desc => "the month is rendered as a separate string into the gap" },

"新しい月、   となりました!" => { tr =>
"A new month,   , is here!", ok   => 'a-csharp 4572679',
desc => "the month is rendered as a separate string into the gap" },

Since i don't know of an easy way right now to affect the spacing of the month (mmmmaybe they're also rendered with prefixed spaces?). A possible solution would appear to be to try and move the underlying english text, by appending spaces. Not sure if that'll work in this case.

As for months in savegames, i see two options:

  • accept that they're broken in the savegame
  • set each month to be exactly the same amount of characters

@miyagami
Copy link
Author

Thought:
Try replacing "A new month" with spaces.
But, only enough to move "is here." to behind the month marker.

2018-12-22_230713

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants