Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check gofmt on PRs #20

Open
bboreham opened this issue Apr 8, 2021 · 2 comments · May be fixed by #56
Open

Check gofmt on PRs #20

bboreham opened this issue Apr 8, 2021 · 2 comments · May be fixed by #56

Comments

@bboreham
Copy link
Collaborator

bboreham commented Apr 8, 2021

Evidently golangci-lint isn't doing it, as seen at #19

@ksudhir007
Copy link

I am interested in contributing to this project. I think this issue is fixed. Looking at the #64

Run golangci/golangci-lint-action@v2
prepare environment
go env
Installed Go in 68ms
Requested golangci-lint 'latest', using 'v1.41.1', calculation took 94ms
Installing golangci-lint v1.41.1...
Downloading https://github.com/golangci/golangci-lint/releases/download/v1.41.1/golangci-lint-1.41.1-linux-amd64.tar.gz ...
Cache not found for input keys: golangci-lint.cache-2691-23dfab94cf6e959b68510ed62773e31da4864cf2, golangci-lint.cache-2691-, golangci-lint.cache-
/usr/bin/tar xz --overwrite --warning=no-unknown-keyword -C /home/runner -f /home/runner/work/_temp/8a2b2ae7-8d14-4b74-b4e0-9151d3df5732
Installed golangci-lint into /home/runner/golangci-lint-1.41.1-linux-amd64/golangci-lint in 481ms
Prepared env in 577ms

run golangci-lint
  Running [/home/runner/golangci-lint-1.41.1-linux-amd64/golangci-lint run --out-format=github-actions --timeout=5m] in [] ...
  golangci-lint found no issues
  Ran golangci-lint in 73097ms

@bboreham
Copy link
Collaborator Author

I don’t see what you mean at #64.
What happens if you make a PR which does not have the correct formatting?

@basit9958 basit9958 linked a pull request Jun 24, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants