Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to set Prometheus url with custom path without trailing "/" #197

Merged
merged 1 commit into from
Jun 4, 2019
Merged

Add ability to set Prometheus url with custom path without trailing "/" #197

merged 1 commit into from
Jun 4, 2019

Conversation

Laci21
Copy link
Contributor

@Laci21 Laci21 commented Jun 4, 2019

Fixes #193.

What

Join URL paths so that custom path is taken into account.

Additional context

With this change, I was able to install Flagger like this:

helm upgrade -i flagger flagger/flagger \
--namespace=istio-system \
--set metricsServer=http://prometheus.istio-system.svc.cluster.local/prometheus

... and execute a canary deployment based on the docs successfully.

It seems to also work with custom paths with trailing slashes (prometheus/) or without setting any custom paths.

@Laci21 Laci21 requested a review from stefanprodan as a code owner June 4, 2019 15:46
stefanprodan
stefanprodan approved these changes Jun 4, 2019
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @Laci21

@stefanprodan stefanprodan merged commit 00de7ab into fluxcd:master Jun 4, 2019
@Laci21 Laci21 deleted the set-url-custom-path branch June 5, 2019 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support setting Prometheus URL with custom path
2 participants
@Laci21 @stefanprodan