Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not handling empty inventory in GitOpsSet #3726

Open
bigkevmcd opened this issue Dec 14, 2023 · 0 comments
Open

Not handling empty inventory in GitOpsSet #3726

bigkevmcd opened this issue Dec 14, 2023 · 0 comments
Labels
bug Something isn't working severity_medium team/pesto

Comments

@bigkevmcd
Copy link
Contributor

Describe the bug
When the inventory is empty (0 resources created) we get an error.

status:
  conditions:
    - lastTransitionTime: 2023-12-14T00:20:05Z
      message: 0 resources created
      reason: ReconciliationSucceeded
      status: "True"
      type: Ready
  observedGeneration: 2
image

To Reproduce
Create a GitOpsSet that doesn't generate any resources, perhaps with an empty list.

There's a bug filed already to do some validation of the spec requiring some generated resources.

(lists should not be allowed to be empty)

But this could happen if no GitopsClusters matched the labels etc.

Actual behaviour
See error message above

Expected behaviour
No error, perhaps a message showing that there are no resources generated.

Additional context

  • Weave GitOps version:
  • Kubernetes version:
@bigkevmcd bigkevmcd added bug Something isn't working severity_medium team/pesto labels Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working severity_medium team/pesto
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bigkevmcd