Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align object status messages across Explorer and non-Explorer UIs #3729

Open
opudrovs opened this issue Dec 14, 2023 · 0 comments
Open

Align object status messages across Explorer and non-Explorer UIs #3729

opudrovs opened this issue Dec 14, 2023 · 0 comments

Comments

@opudrovs
Copy link
Contributor

opudrovs commented Dec 14, 2023

Based on comments in the following PR, it was noted that there is a slight inconsistency between how object status messages are computed from object conditions in Explorer and in the non-Explorer frontend.

In Explorer, we usually return a message from the object's Ready condition, and if no Ready condition is available, then an empty string:

func defaultFluxObjectMessageFunc(obj client.Object) string {

In the non-Explorer frontend we also try to return a message from a Ready condition first, but if no Ready condition is available, we might return messages from a False condition or the messages from the first of object's conditions:
https://github.com/weaveworks/weave-gitops/blob/cc3c17632334ffa56838c4765e68ce388bde6b2f/ui/components/KubeStatusIndicator.tsx#L64

AC

  • define which way of computing object status messages is preferred.
  • implemented consistently across explorer and non-explorer ui
@opudrovs opudrovs changed the title align object messages across explorer and non-explorer UIs Align object messages across Explorer and non-Explorer UIs Dec 14, 2023
@opudrovs opudrovs changed the title Align object messages across Explorer and non-Explorer UIs Align computing object status messages across Explorer and non-Explorer UIs Dec 14, 2023
@opudrovs opudrovs changed the title Align computing object status messages across Explorer and non-Explorer UIs Align object status messages across Explorer and non-Explorer UIs Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant