Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitops-server helm chart: Missing fields for oidc auth secret #3833

Closed
tommyreilly opened this issue Jul 10, 2023 · 5 comments · Fixed by #4119
Closed

gitops-server helm chart: Missing fields for oidc auth secret #3833

tommyreilly opened this issue Jul 10, 2023 · 5 comments · Fixed by #4119
Labels
bug Something isn't working team/pesto

Comments

@tommyreilly
Copy link

Describe the bug

The documentation for oidc describes the ability to define the following fields for the secret:

https://docs.gitops.weave.works/docs/configuration/oidc-access/#scopes

  --from-literal=tokenDuration=<token-duration> \
  --from-literal=customScopes=custom,scopes

https://docs.gitops.weave.works/docs/configuration/oidc-access/#claims

  --from-literal=claimUsername=sub \
  --from-literal=claimGroups=groups

The gitops-server helm chart secret does not provide the ability to set these fields in the oidc-auth-secret.yaml and they are not referenced in the values.yaml

https://github.com/weaveworks/weave-gitops/blob/main/charts/gitops-server/templates/oidc-auth-secret.yaml

# https://docs.gitops.weave.works/docs/configuration/securing-access-to-the-dashboard/#login-via-an-oidc-provider
oidcSecret:
  create: false
  # clientID:
  # clientSecret:
  # issuerURL:
  # redirectURL:

Environment

  • Weave-Gitops Version: v0.27.0
  • Flux Version: 2.0.0
  • Kubernetes version: 1.26

Expected behavior

This is a request to enhance the chart to include these fields

@tommyreilly tommyreilly added the bug Something isn't working label Jul 10, 2023
@tommyreilly tommyreilly changed the title gitops-server helm char: Missing fields for oidc auth secret gitops-server helm chart: Missing fields for oidc auth secret Jul 10, 2023
@bigkevmcd
Copy link
Contributor

bigkevmcd commented Jul 13, 2023

@tommyreilly thanks for reporting this, we'll get it addressed as an issue.

@tommyreilly
Copy link
Author

Thanks @bigkevmcd, appreciate it.

Tommy

@AhmedQaziMuhammadJamil
Copy link

Hi @bigkevmcd I am also facing the same issue. I tried to add customscopes and Claimgroups through the values.yaml but the outcome is the same.The secret is never created with customscopes and Claimgroups.

@dmcanally-leolabs
Copy link

I see the PR got closed. I'm having this same issue as well.

@bcorijn
Copy link
Contributor

bcorijn commented Nov 2, 2023

I opened up a new PR, I missed the previous one got closed until I already had my fork ready, but I feel there's still a need/use case for this anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working team/pesto
Projects
None yet
6 participants