Obtain container hostname from specified Docker container label

[2opremio]

TL;DR Add a new flag to weave proxy --hostname-from-label which specifies a label key from which to extract the container's hostname.

We already added --hostname-match and --hostname-replacement to the proxy, allowing to derive hostnames from transformations of container names (see #1126).

For ECS this is not enough since the original specified container names are mangled destructively, not allowing to retrieve the original name at spawning time.

However, I just found out that ECS adds a label, com.amazonaws.ecs.container-name, to every container with the original container name.

We can add a new flag to weave proxy, --hostname-from-label to specifiy a label key from which to extract the container's hostname.

[rade]

We can add a new flag to weave proxy, --hostname-from-label to specifiy a label key from which to extract the container's hostname.

And this could work in conjunction with the existing options, right?

[2opremio]

Yes, I don't see a reason why it wouldn't.

[rade]

ok. hurry up, let's try to get this into 1.1 :)

[2opremio]

I'm on it!

[faddat]

Can you give me an example of how I can use this?

[faddat]

Nevermind. I did not know what docker labels could take key+value. For the next ignorant sucker:

From the docker docs:

label (label= or label==)