Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure limiting behaviour is correct for groups. #364

Open
shans opened this issue Jun 5, 2015 · 1 comment
Open

Ensure limiting behaviour is correct for groups. #364

shans opened this issue Jun 5, 2015 · 1 comment

Comments

@shans
Copy link
Contributor

shans commented Jun 5, 2015

For example, 'end delays on groups work correctly' test in group-animation.js should have these lines at the end.

assert.equal(getComputedStyle(this.target).marginLeft, '4px');
tick(105);
assert.equal(getComputedStyle(this.target).marginLeft, '0px');

@rjwright
Copy link
Contributor

It is true that seeking a group can cause the childrens' current times to extend past their active duration, but that is not the reason for this bug

For example, 'end delays on groups work correctly' test in group-animation.js should have these lines at the end.

assert.equal(getComputedStyle(this.target).marginLeft, '4px');
tick(105);
assert.equal(getComputedStyle(this.target).marginLeft, '0px');

See #375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants