Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PublicKeyCredentialCreationOptions::create() is marked as @private #481

Closed
TimWolla opened this issue Sep 18, 2023 · 3 comments · Fixed by #489
Closed

PublicKeyCredentialCreationOptions::create() is marked as @private #481

TimWolla opened this issue Sep 18, 2023 · 3 comments · Fixed by #489
Milestone
4.7.2

Comments

@TimWolla
Copy link
Contributor

I don't think this is intentional, because both the __construct() and create() are @private:

webauthn-framework/src/webauthn/src/PublicKeyCredentialCreationOptions.php

Line 78 in fbdcf73

* @private

@Spomky
Copy link
Contributor

Spomky commented Sep 18, 2023

Indeed. My mistake.
I will fix that.

@Spomky Spomky linked a pull request Sep 29, 2023 that will close this issue
@private statement removed #489
Merged
4 tasks
@Spomky Spomky added this to the 4.7.2 milestone Sep 29, 2023
@Spomky
Copy link
Contributor

Spomky commented Sep 29, 2023

Closing as resolved.
Will be fixed in 4.7.2.

@Spomky Spomky closed this as completed Sep 29, 2023
@github-actions
Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.7.2
Development

Successfully merging a pull request may close this issue.

@private statement removed web-auth/webauthn-framework
2 participants
@TimWolla @Spomky