Paramater residentKey will be ignored when Initializing AuthenticatorSelectionCriteria

[tomocrafter]

Version(s) affected

4.7.4

Description

Paramater residentKey will be ignored when Initializing AuthenticatorSelectionCriteria

How to reproduce

new AuthenticatorSelectionCriteria(null, "preferred", "required")->residentKey;

Possible Solution

This line should be $this->residentKey = $residentKey !== null ? $residentKey : ($requireResidentKey === true ? self::RESIDENT_KEY_REQUIREMENT_REQUIRED : self::RESIDENT_KEY_REQUIREMENT_PREFERRED);

webauthn-framework/src/webauthn/src/AuthenticatorSelectionCriteria.php

Line 80 in d7b7eb7

$this->residentKey = $residentKey !== null ? $this->residentKey : ($requireResidentKey === true ? self::RESIDENT_KEY_REQUIREMENT_REQUIRED : self::RESIDENT_KEY_REQUIREMENT_PREFERRED);

Additional Context

No response

[Spomky]

Hi,

Indeed, there is something wrong with this line.
I will address this issue ASAP

[tomocrafter]

Hi, Thank you for response and commiting to this great library! It was hard to find solid library for webauthn in PHP so I am so pleasure to meet to this.

Thank you for looking into this problem as well, I think this can be fixed by my suggestion so Can I open the pull request with these changes?

[Spomky]

Done. Will be tagged soon

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.