Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use findLogins() for efficiency #4

Open
aswan opened this issue Oct 8, 2016 · 1 comment
Open

Use findLogins() for efficiency #4

aswan opened this issue Oct 8, 2016 · 1 comment

Comments

@aswan
Copy link
Collaborator

aswan commented Oct 8, 2016

The current implementation was cribbed from the add-on sdk passwords module which uses getAllLogins() and then filters the results. For scenarios where a user has lots of stored login information, we can be a lot more efficient by using findLogins()

@bobsilverberg
Copy link

This has been addressed in the patch for [1]. I will mark this as fixed when that patch lands.

[1] https://bugzil.la/1324919

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants