build: clean build script, restrict hoist of pnpm #1286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chenjiahan
reviewed
Jan 16, 2024
| @@ -147,17 +147,17 @@ pnpm run --filter @rsbuild/some-package test | |||
|
|
|||
There was a problem hiding this comment.
This PR contains several changes, can you split them to into separate PRs? 😄
Small PR is better for reviewing and generating changelog.
There was a problem hiding this comment.
Sure. I'm closing this PR for now.
This was referenced Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cwdfor certain test cases to correctly resolve dependencies after hoisting has been restricted. (By the way, I believe all the current working directories should be set to the case directory instead of the current working directory, which is the workspace root now.)e2e/cases/mjs-artifact/test.mjswould fail becauseglobal.requirewill be set concurrently and fail due to the non-availability of the phantom dependency.Related Links
Checklist