Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: hrm slow #1590

Closed
liangyuetian opened this issue Feb 20, 2024 · 6 comments
Closed

[Bug]: hrm slow #1590

liangyuetian opened this issue Feb 20, 2024 · 6 comments
Labels
🐞 bug Something isn't working

Comments

@liangyuetian
Copy link

Version

System:
    OS: macOS 14.2.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 217.88 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Browsers:
    Chrome: 121.0.6167.184
    Safari: 17.2.1
  npmPackages:
    @rsbuild/core: ^0.4.3 => 0.4.3 
    @rsbuild/plugin-vue: ^0.4.3 => 0.4.3

Details

Slow speed when editing files with and without dependencies
image

related issues:
#1397

Reproduce link

https://github.com/liangyuetian/rsbuild-hmr-slow-demo

Reproduce Steps

  1. pnpm install
  2. npm run dev (Client compiled in 3.7 s)
  3. edit src/pages/test_1.vue (Client compiled in 2.4 s)
@liangyuetian liangyuetian added the 🐞 bug Something isn't working label Feb 20, 2024
@chenjiahan
Copy link
Member

Get, we will track the performance issues in this repo.

@chenjiahan
Copy link
Member

Half of the overhead is generated by html-webpack-plugin / html-rspack-plugin. If we try to set tools.htmlPlugin to false, the HMR time will be reduced by half.

@liangyuetian
Copy link
Author

Half of the overhead is generated by html-webpack-plugin / html-rspack-plugin. If we try to set tools.htmlPlugin to false, the HMR time will be reduced by half.

@chenjiahan set tools.htmlPlugin to false can reduce time, but it is not very helpful for hmr updates. For such a simple entry, the expected time should be 0.0x ms
image

@chenjiahan
Copy link
Member

chenjiahan commented Feb 20, 2024

0.0x ms is impossible. Do you mean 0.0x second?

The HMR time may be reduced to less than 100ms after Rspack providing better incremental build and supporting persistent cache.

@liangyuetian
Copy link
Author

0.0x ms is impossible. Do you mean 0.0x second?
The HMR time may be reduced to less than 100ms after Rspack providing better incremental build and supporting persistent cache.

reliable

@liangyuetian
Copy link
Author

image

v0.5.6 awesome

looking forward to version 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants