Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: reflect git ignores for biome's ignore list #884

Closed
xc2 opened this issue Apr 1, 2024 · 0 comments · Fixed by #903
Closed

[Feature]: reflect git ignores for biome's ignore list #884

xc2 opened this issue Apr 1, 2024 · 0 comments · Fixed by #903

Comments

@xc2
Copy link
Collaborator

xc2 commented Apr 1, 2024

What problem does this feature solve?

automatically extends biome's ignore list with .gitignore via enabling vcs.useIgnoreFile

biome's performance will expectedly be slightly affected, but it will still be fast.

         Worth a separate PR 😄

Originally posted by @chenjiahan in #851 (comment)

What does the proposed API look like?

add vcs config and remove duplicated ignore items

diff --git a/biome.json b/biome.json
index 24e9a0e2..2b5865fe 100644
--- a/biome.json
+++ b/biome.json
@@ -23,17 +23,13 @@
     ],
     "ignore": [
       "*.d.ts",
-      "dist/**/*",
       "dist-*/**/*",
-      "doc_build/**/*",
       "compiled/**/*",
-      "node_modules/**/*",
-      "create-rspress/template/rspress.config.ts",
-      ".history/**/*",
-      "coverage/**/*"
+      "create-rspress/template/rspress.config.ts"
     ],
     "ignoreUnknown": true
   },
+  "vcs": {/* ... */},
   "formatter": {
     "indentStyle": "space"
   },
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants