Skip to content
This repository has been archived by the owner on Nov 6, 2019. It is now read-only.

Add endpoint for surfacing 'latest' test run #161

Closed
lukebjerring opened this issue Oct 17, 2017 · 3 comments
Closed

Add endpoint for surfacing 'latest' test run #161

lukebjerring opened this issue Oct 17, 2017 · 3 comments

Comments

@lukebjerring
Copy link
Collaborator

lukebjerring commented Oct 17, 2017

The endpoint could help us determine state-changes for test runs (i.e. detect when a PR is changing the state of a test to be failing when it was passing).
(See web-platform-tests/wpt#7475 for context)

e.g. it would be nice if instead of
https://storage.googleapis.com/wptd/b12daf6ead/safari-10-macos-10.12-sauce/IndexedDB/abort-in-initial-upgradeneeded.html
we could just call
https://storage.googleapis.com/wptd/latest/safari-10-macos-10.12-sauce/IndexedDB/abort-in-initial-upgradeneeded.html
where latest works out what to load.

If we can't do so in cloud storage's API, we can add an endpoint somewhere like wpt.fyi/lastest/[test name]

@jeffcarp
Copy link
Contributor

Deployed #166, however it looks like we're missing a datastore index:

https://wpt.fyi/latest/chrome-63.0-linux

I haven't double checked but I think adding this to index.yaml will resolve the issue:

- kind: TestRun
  properties:
  - name: BrowserVersion
  - name: OSName
  - name: CreatedAt
    direction: desc
- kind: TestRun
  properties:
  - name: BrowserVersion
  - name: OSName
  - name: OSVersion
  - name: CreatedAt
    direction: desc

@lukebjerring
Copy link
Collaborator Author

There's currently a bug with trailing slash handling (fixed in #168).

However, I'm reconsidering the choice of path for this. I think instead we should be changing the endpoint to be "/json", with ?platform=chrome. /latest is more relevant to the dashboard itself (see
#172).

@jeffcarp
Copy link
Contributor

jeffcarp commented Nov 1, 2017

I believe this is completed?

@jeffcarp jeffcarp closed this as completed Nov 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants