Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store results of web-platform-tests PRs and allow comparing to master #118

Closed
foolip opened this issue May 3, 2018 · 4 comments
Closed
Assignees

Comments

@foolip
Copy link
Member

foolip commented May 3, 2018

This would be part of a solution to web-platform-tests/wpt#7475 that doesn't involve https://pulls.web-platform-tests.org/.

Doing web-platform-tests/wpt#10503 first might make this simpler, but it isn't strictly required, we could also get results from Travis.

@zcorpan
Copy link
Member

zcorpan commented May 15, 2018

This is blocked on web-platform-tests/wpt#9874

@lukebjerring
Copy link
Contributor

Whether we should do this is up for debate, regarding Travis CI secrets. We are not able to pull from Travis CI after the results report has been produced, so would have to push from Travis CI. This requires basic HTTP authentication (see API docs).

IMHO, it's fine to have a Travis login and secret, and special-case it in the endpoint to be flagged as untrusted in case we need to do anything extra special later in the UI. Note, also, that we could additionally lock that login down, using say, Travis IPs.

I think there's a lot of value added having these runs in our dataset.

@lukebjerring
Copy link
Contributor

@Hexcles, I trust you to make the right decision ;)

@lukebjerring
Copy link
Contributor

This is now a dupe of the implementation-specific #707.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants