Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

w3c-test.org link for PR results is broken/confusing #1322

Open
zcorpan opened this issue May 28, 2019 · 1 comment
Open

w3c-test.org link for PR results is broken/confusing #1322

zcorpan opened this issue May 28, 2019 · 1 comment

Comments

@zcorpan
Copy link
Member

zcorpan commented May 28, 2019

See e.g.
https://wpt.fyi/results/css/css-ui/control-internal-pseudo-elements-getComputedStyle-001.html?sha=c12c73e623

There's a w3c-test.org link, but the test is not in master, it results in a 404, and this is confusing:

w3c/csswg-drafts#3980 (comment)

Either remove the link or make it point to the right submissions/ URL if there is one.

@lukebjerring
Copy link
Contributor

This is quite an edge-case; the only users that will wind up looking at a PR that's adding a test are the author or reviewer of the PR, who have the context on the test being newly added (and not existing in master).

However, when this does get tackled, the fix is to omit the link when the fetched manifest doesn't have an entry for the test that we're currently looking at (which is a small branch away from the code that already maps generated tests to their source file, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants