From 97d4646fd82ae91238bf0c8bb8f941a0db10ecfb Mon Sep 17 00:00:00 2001
From: Darren Shen <shend@chromium.org>
Date: Tue, 27 Mar 2018 02:18:24 -0700
Subject: [PATCH] [css-typed-om] Stub list-valued tests.

Currently we're just adding a TODO when we want to test a list-valued
property. It's probably easier if we stub that test function and then
implement it later.

Bug: 774887
Change-Id: Iab3cea915afbcc8490cacbd45e5632a18e7dece1
Reviewed-on: https://chromium-review.googlesource.com/981956
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546067}
---
 .../properties/animation-direction.html                     | 3 +--
 .../the-stylepropertymap/properties/background-image.html   | 3 +--
 .../the-stylepropertymap/properties/mask-image.html         | 3 +--
 .../the-stylepropertymap/properties/resources/testsuite.js  | 6 ++++++
 .../properties/transition-duration.html                     | 3 +--
 5 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/css/css-typed-om/the-stylepropertymap/properties/animation-direction.html b/css/css-typed-om/the-stylepropertymap/properties/animation-direction.html
index 8ab03635042777..0d4f6c02952cd8 100644
--- a/css/css-typed-om/the-stylepropertymap/properties/animation-direction.html
+++ b/css/css-typed-om/the-stylepropertymap/properties/animation-direction.html
@@ -13,8 +13,7 @@
 <script>
 'use strict';
 
-// FIXME: animation-direction is list-valued. Run list-valued tests here too.
-runPropertyTests('animation-direction', [
+runListValuedPropertyTests('animation-direction', [
   { syntax: 'normal' },
   { syntax: 'reverse' },
   { syntax: 'alternate-reverse' },
diff --git a/css/css-typed-om/the-stylepropertymap/properties/background-image.html b/css/css-typed-om/the-stylepropertymap/properties/background-image.html
index d584a0ff3e4d70..b3dddedbe4a9ce 100644
--- a/css/css-typed-om/the-stylepropertymap/properties/background-image.html
+++ b/css/css-typed-om/the-stylepropertymap/properties/background-image.html
@@ -13,8 +13,7 @@
 <script>
 'use strict';
 
-// FIXME: background-image is list-valued. Run list-valued tests here too.
-runPropertyTests('background-image', [
+runListValuedPropertyTests('background-image', [
   { syntax: 'none' },
   { syntax: '<image>' },
 ]);
diff --git a/css/css-typed-om/the-stylepropertymap/properties/mask-image.html b/css/css-typed-om/the-stylepropertymap/properties/mask-image.html
index f306fdde92baaa..aa858d2e46bf09 100644
--- a/css/css-typed-om/the-stylepropertymap/properties/mask-image.html
+++ b/css/css-typed-om/the-stylepropertymap/properties/mask-image.html
@@ -13,8 +13,7 @@
 <script>
 'use strict';
 
-// FIXME: mask-image is list-valued. Run list-valued tests here too.
-runPropertyTests('mask-image', [
+runListValuedPropertyTests('mask-image', [
   { syntax: 'none' },
   { syntax: '<image>' },
 ]);
diff --git a/css/css-typed-om/the-stylepropertymap/properties/resources/testsuite.js b/css/css-typed-om/the-stylepropertymap/properties/resources/testsuite.js
index 2c20c05e7d0f0d..bf2b217177c6fd 100644
--- a/css/css-typed-om/the-stylepropertymap/properties/resources/testsuite.js
+++ b/css/css-typed-om/the-stylepropertymap/properties/resources/testsuite.js
@@ -378,6 +378,12 @@ function runPropertyTests(propertyName, testCases) {
   }
 }
 
+// Same as runPropertyTests but for list-valued properties.
+function runListValuedPropertyTests(propertyName, testCases) {
+  // TODO(https://crbug.com/545318): Run list-valued tests as well.
+  runPropertyTests(propertyName, testCases);
+}
+
 // Check that |propertyName| doesn't "support" examples in |testExamples|.
 // |testExamples| is a list of CSS string values. An "unsupported" value
 // doesn't have a corresponding Typed OM representation. It normalizes as
diff --git a/css/css-typed-om/the-stylepropertymap/properties/transition-duration.html b/css/css-typed-om/the-stylepropertymap/properties/transition-duration.html
index c17e717ba91c18..c0eb09daa7622c 100644
--- a/css/css-typed-om/the-stylepropertymap/properties/transition-duration.html
+++ b/css/css-typed-om/the-stylepropertymap/properties/transition-duration.html
@@ -12,8 +12,7 @@
 <script>
 'use strict';
 
-// FIXME: transition-duration is list-valued. Run list-valued tests here too.
-runPropertyTests('transition-duration', [
+runListValuedPropertyTests('transition-duration', [
   { syntax: '<time>' },
 ]);