Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css/selectors/attribute-selectors/attribute-case/syntax.html test has inconsistent names of subtests #14003

Closed
foolip opened this issue Nov 9, 2018 · 6 comments

Comments

@foolip
Copy link
Member

foolip commented Nov 9, 2018

https://wpt.fyi/results/css/selectors/attribute-selectors/attribute-case/syntax.html?sha=71fe0a6c3d

In Edge, in addition to the failures, the subtests names are different, some are missing and there's an extra "[foo='bar' i" test at the end which I cannot find in the source.

This seems likely to be a test bug.

@jugglinmike is this a sort of anomaly that shows up in any report we have?

@gsnedders
Copy link
Member

gsnedders commented Nov 20, 2018

I don't really understand how this could be a test bug? It's a pretty simple sequence of sync tests…

Almost all the missing tests are ones with null bytes in them, so I presume something somewhere is failing with that?

@foolip
Copy link
Member Author

foolip commented Nov 23, 2018

Hmm, possibly an infra problem then. If null bytes are involved, then somewhere along the line a string is stored as a C string. Maybe that's an Edge bug? Or Sauce? Would need to debug.

@jugglinmike
Copy link
Contributor

I'm on the case!

@jugglinmike
Copy link
Contributor

This is the result of a deficiency in Edge/Edgedriver: string literals transmitted via the "Execute Script" and "Execute Async Scripts" commands are truncated at the first null byte.

I've submitted a WebDriver conformance test to alert the Edge maintainers, and I've suggested a more immediate solution for WPT via gh-14245.

@jugglinmike
Copy link
Contributor

@foolip We never did come to a conclusion for unprintable characters in test names, but now that Edge has a new WebDriver implementation which tolerates that case (as evidenced by recent test
results
), the issue is less relevant. I'm going to un-assign myself and recommend my fix, unpopular though it may be--gh-14245.

@jugglinmike jugglinmike removed their assignment Nov 15, 2019
@foolip
Copy link
Member Author

foolip commented Nov 15, 2019

Alright, I'll just go ahead and close this because without something to surface the problem it won't ever be a priority for anyone.

@foolip foolip closed this as completed Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants