Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some User Timing tests are flaky #14434

Open
foolip opened this issue Dec 10, 2018 · 1 comment
Open

Some User Timing tests are flaky #14434

foolip opened this issue Dec 10, 2018 · 1 comment

Comments

@foolip
Copy link
Member

foolip commented Dec 10, 2018

#14409 (comment) lists a number of tests in user-timing/ that were flaky in Firefox:

Test Subtest Results Messages
/user-timing/measure_associated_with_navigation_timing.html Second measure of current mark to navigationStart should be negative value. FAIL: 1/10, PASS: 9/10 assert_true: Second measure of current mark to navigationStart should be negative value. expected true got false
/user-timing/measure_associated_with_navigation_timing.html Measure from domComplete event to most recent mark "a" should have longer duration. FAIL: 1/10, PASS: 9/10 assert_true: Measure from domComplete event to most recent mark "a" should have longer duration. expected true got false
/user-timing/measure_associated_with_navigation_timing.html Measure from most recent mark to navigationStart should have longer duration. FAIL: 1/10, PASS: 9/10 assert_true: Measure from most recent mark to navigationStart should have longer duration. expected true got false

Suggested method to investigate:

  1. Add a trailing whitespace or other no-op to all tests in user-timing/ in a test PR
  2. Check which were flaky on Taskcluster
  3. Fix them :)
@foolip
Copy link
Member Author

foolip commented Dec 10, 2018

Notifying suggested reviewers for user-timing: @plehegar @igrigorik @toddreifsteck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant