Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to run all tests for a PR sometimes #18755

Closed
LukeZielinski opened this issue Aug 29, 2019 · 4 comments
Closed

Make it possible to run all tests for a PR sometimes #18755

LukeZielinski opened this issue Aug 29, 2019 · 4 comments

Comments

@LukeZielinski
Copy link
Contributor

Wondering if we can make it possible for WPT to run all tests on a PR conditionally (eg: based on the presence of a particular label, or some kind of special tag in a PR description).

So if we add a label called "force-all-tests" to a PR then we could run a check equivalent to the "Taskcluster (push)" check.

Currently, this can be done by hacking .taskcluster.yml on a local fork and then doing some more hacking to manually upload the results to wpt.fyi. But this is highly brittle and error prone, would be nice if we could choose to run all tests when needed by a particular change.

@LukeZielinski
Copy link
Contributor Author

@lukebjerring @Hexcles @jgraham @foolip WDYT?

@lukebjerring
Copy link
Contributor

Also @jugglinmike definitely does this on occasion hackily.

@jugglinmike
Copy link
Contributor

The way I do this is sensitive and graceful

@foolip
Copy link
Member

foolip commented Aug 29, 2019

I agree we need this, I've even requested it before :)

Closing as dupe of #13263, please suggest how to do it there :)

@foolip foolip closed this as completed Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants