You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For a long time, Web IDL "class string" behavior was non-interoperable. As such, currently assert_class_string only tests the interoperable subset: basically, does Object.prototype.toString() produce the right result on instances. This is good, because if it tested the full spec semantics, then every idlharness-based test would get a bunch of noisy failures for areas outside the interoperable subset. Instead, we tested the full spec semantics for one or two interfaces in the WebIDL/ directory.
However, we seem to be converging on interoperability. In particular, whatwg/webidl#357 has been merged, with implementer support. Once implementers implement it, we should consider expanding test coverage for class strings to test the full spec semantics.
We should not do this right away, to avoid the thousands-of-noisy-failures issue. But once implemented, we can do so, for the following benefits:
Gives full coverage of all classes, not just a few. In particular this is important for classes like WebAssembly or Streams, which might be implemented using different technology. For example, we could revert WASM JS API: Test new Web IDL class string behavior #23205 and let idlharness take care of it.
Lets us remove most of the class string tests in the WebIDL/ folder.
Note that this work was started in #23108, but I asked that it be put on hold. So this issue is basically to track reopening and merging that PR in a future time.
For a long time, Web IDL "class string" behavior was non-interoperable. As such, currently
assert_class_string
only tests the interoperable subset: basically, doesObject.prototype.toString()
produce the right result on instances. This is good, because if it tested the full spec semantics, then every idlharness-based test would get a bunch of noisy failures for areas outside the interoperable subset. Instead, we tested the full spec semantics for one or two interfaces in the WebIDL/ directory.However, we seem to be converging on interoperability. In particular, whatwg/webidl#357 has been merged, with implementer support. Once implementers implement it, we should consider expanding test coverage for class strings to test the full spec semantics.
We should not do this right away, to avoid the thousands-of-noisy-failures issue. But once implemented, we can do so, for the following benefits:
Gives full coverage of all classes, not just a few. In particular this is important for classes like WebAssembly or Streams, which might be implemented using different technology. For example, we could revert WASM JS API: Test new Web IDL class string behavior #23205 and let idlharness take care of it.
Lets us remove most of the class string tests in the WebIDL/ folder.
Note that this work was started in #23108, but I asked that it be put on hold. So this issue is basically to track reopening and merging that PR in a future time.
/cc @annevk @shvaikalesh @evilpie @TimothyGu
The text was updated successfully, but these errors were encountered: