Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eventsource tests are broken under python3 #23436

Closed
jdm opened this issue May 6, 2020 · 4 comments
Closed

Eventsource tests are broken under python3 #23436

jdm opened this issue May 6, 2020 · 4 comments

Comments

@jdm
Copy link
Contributor

jdm commented May 6, 2020

Judging by the comment in #23284 this is expected. It broke Servo's nightly sync, however, since we're running a small set of tests (/eventsource) under python3 to verify the rest of our test infrastructure still works.

@stephenmcgruer
Copy link
Contributor

cc @Hexcles @jgraham as an FYI

This will eventually be fixed as we upgrade handlers to Python 3, but perhaps we could fix the eventsource/ ones ahead of web-platform-tests/rfcs#49 being ratified given that we're sort of regressing here?

@jdm - does it need to be those tests you run, or could you run some that don't depend on the python file handler support?

@jdm
Copy link
Contributor Author

jdm commented May 6, 2020

Running any small set of tests is fine for our purposes. I nearly have all of the handlers fixed to get the tests passing again, but there are a couple stragglers that do special things with encodings, of course.

@Hexcles
Copy link
Member

Hexcles commented Jul 14, 2020

@jdm has #24184 fixed this issue?

@jdm
Copy link
Contributor Author

jdm commented Jul 14, 2020

Yep.

@jdm jdm closed this as completed Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants