Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why convert app server key w/ urlBase64ToUint8Array #577

Closed
4r7d3c0 opened this issue Apr 18, 2020 · 2 comments
Closed

Why convert app server key w/ urlBase64ToUint8Array #577

4r7d3c0 opened this issue Apr 18, 2020 · 2 comments

Comments

@4r7d3c0
Copy link
Contributor

4r7d3c0 commented Apr 18, 2020

The spec states that the applicationServerKey can be passed as DOMString in base64url which the lib generated already. why convert.
https://w3c.github.io/push-api/#pushsubscriptionoptions-interface

@4r7d3c0 4r7d3c0 changed the title Why convert app server key to urlBase64ToUint8Array Why convert app server key w/ urlBase64ToUint8Array Apr 18, 2020
@4r7d3c0
Copy link
Contributor Author

4r7d3c0 commented Apr 18, 2020

ah i guess it was for the older chrome
Screenshot 2020-04-19 at 02 33 21

@4r7d3c0 4r7d3c0 closed this as completed Apr 18, 2020
@marco-c
Copy link
Member

marco-c commented Apr 18, 2020

See also #558.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants