Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0] account management inconsistency #1204

Closed
connectdotz opened this issue Nov 28, 2017 · 3 comments
Closed

[1.0] account management inconsistency #1204

connectdotz opened this issue Nov 28, 2017 · 3 comments
Assignees
Labels
Enhancement Includes improvements or optimizations

Comments

@connectdotz
Copy link

Trying to use the new eth.accounts to manage the local wallet, noticed that in Method.sendRequest, it only routed 2 RPC to the accounts object: eth_sendTransaction and eth_sign, but not eth_accounts .... so potentially eth.getAccouts() and eth.accounts could return different results... is that by design or just a bug?

@connectdotz
Copy link
Author

connectdotz commented Nov 28, 2017

looks like this problem is bigger than I thought. Found related issue (#1154), apparently there are more RPC api not get intercepted for account transformation in sendRequest, such as the personal API... I am now more concerned that this inconsistency could be a serious issue ‼️ if some API is getting account information from eth.accounts while others from RPC provider...

@connectdotz connectdotz changed the title [1.0] eth.accounts vs. eth.getAccounts (inconsistent?) [1.0] account management inconsistency Nov 28, 2017
@connectdotz
Copy link
Author

connectdotz commented Nov 29, 2017

Based on the code and documents, I assume the following: if the local accounts (eth.accounts) are available, they should be used for all API consistently.

web3 team, we could help fix it but would need to know if this assumption aligns with your intended design...

@Stradivario
Copy link

So no one gives a shit about it right ? :D it is totally messy everything... the types are completely wrong methods that not exists...they..do..exist and i am like "debugger" everywhere to see what they put inside this object :D back to 2001 :D

@nivida nivida self-assigned this Aug 9, 2018
@nivida nivida added the Needs Clarification Requires additional input label Nov 29, 2018
@nivida nivida added Enhancement Includes improvements or optimizations and removed Needs Clarification Requires additional input labels Apr 2, 2019
@nivida nivida mentioned this issue Apr 4, 2019
12 tasks
@nivida nivida mentioned this issue Nov 21, 2019
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Includes improvements or optimizations
Projects
None yet
Development

No branches or pull requests

3 participants