-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.0] account management inconsistency #1204
Comments
looks like this problem is bigger than I thought. Found related issue (#1154), apparently there are more RPC api not get intercepted for account transformation in sendRequest, such as the personal API... I am now more concerned that this inconsistency could be a serious issue |
Based on the code and documents, I assume the following: if the local accounts (eth.accounts) are available, they should be used for all API consistently. web3 team, we could help fix it but would need to know if this assumption aligns with your intended design... |
So no one gives a shit about it right ? :D it is totally messy everything... the types are completely wrong methods that not exists...they..do..exist and i am like "debugger" everywhere to see what they put inside this object :D back to 2001 :D |
Trying to use the new eth.accounts to manage the local wallet, noticed that in Method.sendRequest, it only routed 2 RPC to the accounts object:
eth_sendTransaction
andeth_sign
, but noteth_accounts
.... so potentially eth.getAccouts() and eth.accounts could return different results... is that by design or just a bug?The text was updated successfully, but these errors were encountered: