Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconnect feature is missing when websocket connection is closed. #1852

Closed
nujabes403 opened this issue Aug 7, 2018 · 4 comments
Closed

Reconnect feature is missing when websocket connection is closed. #1852

nujabes403 opened this issue Aug 7, 2018 · 4 comments
Assignees
@nivida
Labels
Needs Clarification Requires additional input

Comments

@nujabes403
Copy link
Contributor

Expected behavior
After websocket connection is closed, it should try reconnecting.

Actual behavior
After websocket connection is closed, it doesn't do anything except notifying "connection is closed".

Steps to reproduce the behavior
Try offline mode on chrome developer tool.

Versions
npm 5.6.0
node 8.11.3
web3js 1.0.0.beta-35
OS X high sierra
@nujabes403
Copy link
Contributor Author

fix on #1851

@nujabes403 nujabes403 mentioned this issue Aug 7, 2018
Closed
12 tasks
@levino
Copy link
Contributor

levino commented Aug 8, 2018

The PR does not solve this issue. Also I think this is a non-issue. See PR review. I vote for closing this issue as 'wontfix'.

@nivida nivida self-assigned this Aug 10, 2018
@nivida nivida added the Needs Clarification Requires additional input label Aug 10, 2018
@ArsenKulikov
Copy link

@levino @nujabes403
so, is there any solution of this problem?

@gabmontes gabmontes mentioned this issue Sep 22, 2018
Closed
12 tasks
@nivida
Copy link
Contributor

nivida commented Nov 28, 2018 •
edited
Loading

I'm closing this PR because of the PR #1966

@nivida nivida closed this as completed Nov 28, 2018
@alcuadrado alcuadrado mentioned this issue Sep 16, 2019
Closed
@nivida nivida mentioned this issue Nov 8, 2019
Merged
11 tasks
@nivida nivida mentioned this issue Nov 21, 2019
Closed
7 tasks
@ryanio ryanio mentioned this issue Apr 15, 2020
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nivida nivida

Labels
Needs Clarification Requires additional input
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@levino @nivida @nujabes403 @ArsenKulikov